Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secbelts can now hold knives. #3455

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

Sadhorizon
Copy link
Contributor

@Sadhorizon Sadhorizon commented Sep 28, 2024

About The Pull Request

Title.

Why It's Good For The Game

A knife is a pretty common piece of sec gear in the frontier actually.

Changelog

🆑
tweak: You can now put knives in secbelts and the subtypes of secbelts.
fix: You can now fit all knives in mining webbings.
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label Sep 28, 2024
@Apogee-dev
Copy link
Contributor

Can you update mining belts too? They can only hold kitchen knives since the knife repath when they should be able to hold any knife.

@FalloutFalcon FalloutFalcon added this pull request to the merge queue Sep 30, 2024
Merged via the queue into shiptest-ss13:master with commit 92df9a1 Sep 30, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Oct 6, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Title.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
A knife is a pretty common piece of sec gear in the frontier actually.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
tweak: You can now put knives in secbelts and the subtypes of secbelts.
fix: You can now fit all knives in mining webbings.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this pull request Dec 24, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Title.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
A knife is a pretty common piece of sec gear in the frontier actually.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
tweak: You can now put knives in secbelts and the subtypes of secbelts.
fix: You can now fit all knives in mining webbings.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants